Skip to content

Conversation

@danieleades
Copy link
Owner

closes #77

there is one downside to this approach i can immediately see, but it's a bit niche- a user cannot retry a write to an output buffer if writing fails during a call to 'flush'.

@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.51%. Comparing base (ad0ccb0) to head (9647548).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   76.51%   76.51%           
=======================================
  Files          11       11           
  Lines         596      596           
=======================================
  Hits          456      456           
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danieleades danieleades changed the title make 'flush' consume self feat!: make 'flush' method on encoder consume 'self' Mar 11, 2025
@danieleades
Copy link
Owner Author

@DCNick3 is this what you had in mind?

@danieleades danieleades marked this pull request as draft March 11, 2025 12:20
@danieleades danieleades marked this pull request as ready for review March 11, 2025 12:20
@DCNick3
Copy link
Contributor

DCNick3 commented Mar 11, 2025

Yep, pretty much!

@danieleades danieleades merged commit f595437 into main Mar 11, 2025
11 checks passed
@danieleades danieleades deleted the consuming-flush branch March 11, 2025 17:15
@github-actions github-actions bot mentioned this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encoder::encode_all calling flush makes it incompatible with model chaining in a non-obvious way

3 participants