Broaden the test regex #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not everyone stores files in a `tests?` path e.g. some folks classify them with `*.test.coffee` or `*.spec.coffee`.
danielbayley
requested changes
Apr 12, 2019
There was a problem hiding this comment.
@brianmhunt What about something like [^\\s/]*(test|spec).*\\.(#{glob})$
| @@ -6,7 +6,7 @@ task 'generate', "Generate Jest preset JSON config.", => | |||
| preset = | |||
| moduleFileExtensions: [ 'js', 'json', coffee... ] | |||
| transform: "#{glob}": process.env.npm_package_name | |||
| testRegex: "tests?/.*\\.(#{glob})$" | |||
| testRegex: "(tests?)?/.*\\.(#{glob})$" | |||
There was a problem hiding this comment.
@brianmhunt Thanks! But for this to work, wouldn't the / also need to be included in the optional part of the regex though? Something more like (tests?/)?.*\\.(#{glob})$… have you tested it?
There was a problem hiding this comment.
Could be. I’m not using coffeescript on any projects right now so I’m not set up to test it, I’m afraid. Because I can’t easily assist I won’t mind if you close - if you want to clean up the project issues. Can always reopen if others (or future me) come along want it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not everyone stores files in a
tests?path e.g. some folks classify them with*.test.coffeeor*.spec.coffee.