Open
Conversation
Owner
|
@michl-b Thank you for your PR. We'll check it as soon as possible. 👍 |
danielbayerlein
requested changes
Oct 7, 2017
Owner
danielbayerlein
left a comment
danielbayerlein
left a comment
There was a problem hiding this comment.
Thank you for your work! 💚
README.md
Outdated
|
|
||
| #### props | ||
|
|
||
| * `title`: Widget title (Default: `GitHub Issue Count`) |
Owner
There was a problem hiding this comment.
TODO: Default title -> Eureka Health Status
README.md
Outdated
| #### props | ||
|
|
||
| * `title`: Widget title (Default: `GitHub Issue Count`) | ||
| * `interval`: Refresh interval in milliseconds (Default: `300000`) |
README.md
Outdated
| * `interval`: Refresh interval in milliseconds (Default: `300000`) | ||
| * `url`: Eureka Server Base URL | ||
| * `healthQuery`: Relative Path to Spring Boot Actuator Health endpoint | ||
| * `appsQuery`: Relative Path to Eureka Apps API endpoint [Eureka REST operations](https://github.com/Netflix/eureka/wiki/Eureka-REST-operations) |
Owner
There was a problem hiding this comment.
TODO: Remove double whitespace
| * `title`: Widget title (Default: `GitHub Issue Count`) | ||
| * `interval`: Refresh interval in milliseconds (Default: `300000`) | ||
| * `url`: Eureka Server Base URL | ||
| * `healthQuery`: Relative Path to Spring Boot Actuator Health endpoint |
Owner
There was a problem hiding this comment.
TODO: Documentation for baseQuery is missing
README.md
Outdated
| * `appsQuery`: Relative Path to Eureka Apps API endpoint [Eureka REST operations](https://github.com/Netflix/eureka/wiki/Eureka-REST-operations) | ||
| * `authKey`: Credential key, defined in [auth.js](./auth.js) | ||
| * `appNamePattern`: Name pattern the service-names have to start with | ||
| * `minimumInstances`: Number of instances for each service which are expected to run to be fine |
Owner
There was a problem hiding this comment.
TODO: Documentation for minimumInstances default value is missing
| } | ||
| } | ||
|
|
||
| if (hasError === false) { |
| appStatus += ` - ${appsStatus[2]}: ${appsStatus[3]}` | ||
| } | ||
|
|
||
| if (hasError === false) { |
| let infoMessage = '' | ||
| let hasError = json.status !== 'UP' | ||
|
|
||
| if (hasError === false) { |
| appStatus = `${appsStatus[0]}: ${appsStatus[1]}` | ||
| } else { | ||
| appStatus = `${appsStatus[0]}: ${appsStatus[1]}` | ||
| appStatus += ` - ${appsStatus[2]}: ${appsStatus[3]}` |
Owner
There was a problem hiding this comment.
TODO: You can use a single line
appStatus = `${appsStatus[0]}: ${appsStatus[1]} - ${appsStatus[2]}: ${appsStatus[3]}`| return hasError | ||
| } | ||
|
|
||
| async checkInstanceHealth (url, appNamePattern, appList) { |
Owner
There was a problem hiding this comment.
I think we can optimize this function in the next step. @chrishelgert Can you support @michl-b, please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.