fixed logic error with ngf-ignore-invalid

[jonathan-chin]

flag setting line was nested incorrectly
moved to fix

[danialfarid]

I don't see why it is incorrect. Can you create a jsfiddle showing what the issue is and how this fixes it?

[jonathan-chin]

Well, the documentation says:

ngf-ignore-invalid="'pattern maxSize'" // ignore the files that fail the specified validations. They will
// just be ignored and will not show up in ngf-model-invalid or make the form invalid.

For me, the current code wasn't accomplishing the last part, not making the
form invalid.

On Sep 6, 2016 3:35 AM, "Danial Farid" notifications@github.com wrote:

I don't see why it is incorrect. Can you create a jsfiddle showing what
the issue is and how this fixes it?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1685 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHK8tIpuvI_zzqfzcWzh1GfXZp3hRRogks5qnRfLgaJpZM4J1WUt
.

[danialfarid]

Why do you think it makes the form invalid? Can you create an example?

[jonathan-chin]

I wrote a quick sample:

http://jsbin.com/nazoyu/edit?html,js,output

Maybe I'm doing something wrong. The form has the ngf-ignore-invalid attribute but adding an invalid file (anything larger than 1b) still trips errors.

[danialfarid]

I see now, thanks. Fixed at 12.2.6