Skip to content

Fix compilation warnings on recent versions of Elixir #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

axelson
Copy link
Contributor

@axelson axelson commented Jul 10, 2024

I fixed all the compilation warnings on Elixir 1.16

Notes:

The warnings were:

> mix compile --warnings-as-errors
    warning: use Mix.Config is deprecated. Use the Config module instead
    │
  3 │ use Mix.Config
    │ ~~~~~~~~~~~~~~
    │
    └─ config/config.exs:3

Compiling 3 files (.ex)
     warning: single-quoted strings represent charlists. Use ~c"" if you indeed want a charlist or use "" instead
     │
 266 │   if :erlang.system_info(:otp_release) >= '18' do
     │                                           ~
     │
     └─ lib/temp.ex:266:43

I fixed all the compilation warnings on Elixir 1.16

Notes:
- `Config` was added in 1.9 (released 5 years ago)
  https://elixir-lang.org/blog/2019/06/24/elixir-v1-9-0-released/
- sigil_c was added pre-1.0
@danhper
Copy link
Owner

danhper commented Jul 27, 2024

Thanks a lot! I'll push a new version with these fixes

@danhper danhper merged commit efe5870 into danhper:master Jul 27, 2024
@axelson axelson deleted the fix-compilation-warnings branch July 27, 2024 11:56
@axelson
Copy link
Contributor Author

axelson commented Jul 27, 2024

Great, thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants