Fixes for danger pr vs danger WRT async code
#452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking like the config for danger-run isn't aligned, but this is fine, I can fix that before shipping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In facebook/react#11865 I spotted that running
danger prdoesn't actually have the same behavior asdanger- this is becausedanger prused the vm2 runner from Peril, butdangerused the inline process separated runner.The current tradeoff is that this means I removed the REPL. TBH, I wanted that feature because of how well it works in Ruby. JS has
--inspectand I should write up some docs on how to use that instead.