Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DANGER_MANUAL_PR with DANGER_MANUAL_PR_NUM in changelog #1437

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

7rulnik
Copy link
Contributor

@7rulnik 7rulnik commented Apr 16, 2024

It took me a while to figure out why I was getting 327 instead of the value that I passed :D

pr: env.DANGER_TEST_PR || env.DANGER_MANUAL_PR_NUM || "327", // TODO: default to empty string ?

Also, I think a fake provider is worth documenting it, but it's another issue

@orta
Copy link
Member

orta commented Apr 16, 2024

👍 - yeah, no idea where that number came from

@orta orta merged commit 2ff6dad into danger:main Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants