Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defense code for lower gitlab version #1064

Merged
merged 1 commit into from
Aug 29, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/platforms/gitlab/GitLabGit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ const d = debug("GitLabGit")
export const gitLabGitDSL = (gitlab: GitLabDSL, json: GitJSONDSL, gitlabAPI: GitLabAPI): GitDSL => {
const config: GitJSONToGitDSLConfig = {
repo: `${gitlab.mr.project_id}`, // we don't get the repo slug, but `project_id` is equivalent in API calls
baseSHA: gitlab.mr.diff_refs.base_sha,
headSHA: gitlab.mr.diff_refs.head_sha,
baseSHA: gitlab.mr.diff_refs ? gitlab.mr.diff_refs.base_sha : "",
headSHA: gitlab.mr.diff_refs ? gitlab.mr.diff_refs.head_sha : "",
getFileContents: gitlab.utils.fileContents,
getFullDiff: async (base: string, head: string) => {
const changes = await gitlabAPI.getCompareChanges(base, head)
Expand Down