Skip to content

Commit

Permalink
Release 11.2.4
Browse files Browse the repository at this point in the history
  • Loading branch information
orta committed Mar 2, 2023
1 parent 11bab58 commit baec67f
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 14 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "danger",
"version": "11.2.3",
"version": "11.2.4",
"description": "Unit tests for Team Culture",
"main": "distribution/danger.js",
"typings": "distribution/danger.d.ts",
Expand Down
23 changes: 10 additions & 13 deletions source/danger.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import { Gitlab } from "@gitbeaker/node"
import { File } from "parse-diff"

type MarkdownString = string
// TODO: extract out from BitBucket specifically, or create our own type

interface BitBucketCloudJSONDSL {
/** The pull request and repository metadata */
metadata: RepoMetaData
Expand Down Expand Up @@ -197,14 +195,6 @@ interface BitBucketCloudPRActivity {
title: string
}
}
/** Key details about a repo */
interface RepoMetaData {
/** A path like "artsy/eigen" */
repoSlug: string
/** The ID for the pull/merge request "11" */
pullRequestID: string
}

// This is `danger.bitbucket_server` inside the JSON

interface BitBucketServerJSONDSL {
Expand Down Expand Up @@ -1480,9 +1470,6 @@ interface GitHubReviewers {
/** Teams that have been requested */
teams: any[]
}

// TODO: extract out from BitBucket specifically, or create our own type

// getPlatformReviewDSLRepresentation
interface GitLabJSONDSL {
/** Info about the repo */
Expand All @@ -1500,6 +1487,8 @@ interface GitLabJSONDSL {
interface GitLabDSL extends GitLabJSONDSL {
utils: {
fileContents(path: string, repoSlug?: string, ref?: string): Promise<string>
addLabels(...labels: string[]): Promise<boolean>
removeLabels(...labels: string[]): Promise<boolean>
}
api: InstanceType<typeof Gitlab>
}
Expand Down Expand Up @@ -1771,6 +1760,14 @@ interface GitLabApproval {
}[]
| GitLabUser[]
}

/** Key details about a repo */
interface RepoMetaData {
/** A path like "artsy/eigen" */
repoSlug: string
/** The ID for the pull/merge request "11" */
pullRequestID: string
}
/**
* The result of user doing warn, message or fail, built this way for
* expansion later.
Expand Down

0 comments on commit baec67f

Please sign in to comment.