Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More visitor stuff #399

Merged
merged 20 commits into from
Sep 30, 2024
Merged

More visitor stuff #399

merged 20 commits into from
Sep 30, 2024

Conversation

danfuzz
Copy link
Owner

@danfuzz danfuzz commented Sep 30, 2024

This PR fleshes out BaseValueVisitor more completely, including:

  • Giving it three different ways to be called:
    • synchronously, which will appropriately fail if any part of the visit turns out to be coded asynchronously.
    • asynchronously, with a visit-result promise chained to the result of the call.
    • asynchronously, with all visit results — including promises — wrapped, so that an asynchronous visit can be unambiguously differentiated from a visit that results in a promise. (Yay JavaScript!)
  • Adding a bunch of tests.
  • Fixing the original code which (of course) failed a number of the tests.

@danfuzz danfuzz merged commit 4b66894 into main Sep 30, 2024
2 checks passed
@danfuzz danfuzz deleted the more-visiting branch September 30, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant