Simplify / DRY.

danfuzz · Oct 1, 2024 · b52424b · b52424b
1 parent 080e3c3
commit b52424b
Showing 1 changed file with 15 additions and 22 deletions.
diff --git a/src/util/export/BaseValueVisitor.js b/src/util/export/BaseValueVisitor.js
@@ -434,31 +434,24 @@ export class BaseValueVisitor {
     const isArray   = Array.isArray(result);
     const promNames = [];
 
-    for (const name of Object.getOwnPropertyNames(node)) {
-      if (!(isArray && (name === 'length'))) {
-        const got = this.#visitNode(node[name]);
-        if (got.ok === null) {
-          promNames.push(name);
-          result[name] = got.promise;
-        } else if (got.ok) {
-          result[name] = got.result;
-        } else {
-          throw got.error;
+    const addResults = (iter) => {
+      for (const name of iter) {
+        if (!(isArray && (name === 'length'))) {
+          const got = this.#visitNode(node[name]);
+          if (got.ok === null) {
+            promNames.push(name);
+            result[name] = got.promise;
+          } else if (got.ok) {
+            result[name] = got.result;
+          } else {
+            throw got.error;
+          }
         }
       }
-    }
+    };
 
-    for (const name of Object.getOwnPropertySymbols(node)) {
-      const got = this.#visitNode(node[name]);
-      if (got.ok === null) {
-        promNames.push(name);
-        result[name] = got.promise;
-      } else if (got.ok) {
-        result[name] = got.result;
-      } else {
-        throw got.error;
-      }
-    }
+    addResults(Object.getOwnPropertyNames(node));
+    addResults(Object.getOwnPropertySymbols(node));
 
     if (promNames.length === 0) {
       return result;