Skip to content

Commit

Permalink
Note the Node bugs.
Browse files Browse the repository at this point in the history
  • Loading branch information
danfuzz committed Mar 21, 2023
1 parent 9e73184 commit 735ffa1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/network-protocol/private/Http2Wrangler.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ export class Http2Wrangler extends TcpWrangler {
// reference, except the reference had gotten `null`ed out). So, with that
// as context, if -- as we do here -- we tell the session to close as soon
// as we see the underlying socket go away, there's no internal HTTP2 error.
// Salient issues in Node:
// * <https://github.com/nodejs/node/issues/35695>
// * <https://github.com/nodejs/node/issues/46094>
ctx.socket.on('close', () => {
if (!session.closed) {
session.close();
Expand Down

0 comments on commit 735ffa1

Please sign in to comment.