Load OJIP data on-demand#1939
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python | May 28, 2026 9:59p.m. | Review ↗ | |
| Code coverage | May 28, 2026 9:59p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 100% [✓ above threshold] |
99.9% [▼ down 0.1% from main] |
| Python | 100% [✓ above threshold] |
99.9% [▼ down 0.1% from main] |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
joshqsumner
left a comment
There was a problem hiding this comment.
Looks good. Leaving a note here that we should simplify the test_read_cropreporter function once these edits are done
joshqsumner
left a comment
There was a problem hiding this comment.
I like the changes to the tests, should be easier to parse errors and expand to next sub-classes.
Describe your changes
This PR adds new classes for OJIP dark and light measurements, PSD and PSL, respectively. Unlike CHL and CLR data, PSD and PSL load the OJIP data from file each time. We don't expect users to access the PSD and PSL data directly, rather the YII and NPQ analysis functions will instead.
Type of update
Is this a: Work in progress
Associated issues
#1926
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md