Skip to content

Lazy load color#1928

Merged
nfahlgren merged 2 commits into
v5.0from
lazy-load-color
May 26, 2026
Merged

Lazy load color#1928
nfahlgren merged 2 commits into
v5.0from
lazy-load-color

Conversation

@nfahlgren
Copy link
Copy Markdown
Member

@nfahlgren nfahlgren commented May 17, 2026

Describe your changes
PR adds a new class for color data CLR that is used with PSII_data to lazy load the color image on-demand.

ps = pcv.photosynthesis.read_cropreporter("PSII_HDR_020321_WT_TOP_1.INF")
print(ps.clr)
# CLR(filepath='PSII_CLR_020321_WT_TOP_1.DAT', loaded=False)
pcv.plot_image(ps.clr.color)  # plot image
print(ps.clr)
# CLR(filepath='PSII_CLR_020321_WT_TOP_1.DAT', loaded=True)

Type of update
Is this a: New feature or feature enhancement

Associated issues
#1926

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added this to the PlantCV v5.0 milestone May 17, 2026
@nfahlgren nfahlgren added new feature New feature ideas and solutions ready to review merge in order Set of PRs that need to be merged sequentially labels May 17, 2026
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented May 17, 2026

DeepSource Code Review

We reviewed changes in d5434a2...5fe97be on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python May 26, 2026 9:17p.m. Review ↗
Code coverage May 26, 2026 9:17p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
99.9%
[▼ down 0.1% from main]
Python
100%
[✓ above threshold]
99.9%
[▼ down 0.1% from main]

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@joshqsumner joshqsumner self-requested a review May 26, 2026 20:09
Copy link
Copy Markdown
Contributor

@joshqsumner joshqsumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nfahlgren nfahlgren merged commit 05fc169 into v5.0 May 26, 2026
5 checks passed
@nfahlgren nfahlgren deleted the lazy-load-color branch May 26, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge in order Set of PRs that need to be merged sequentially new feature New feature ideas and solutions ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants