Rename filepath to dir #1840
Open
Rename filepath to dir #1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt folder deleted
joshqsumner
added
ready to review
and removed
work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Renamed created columns for relpath from
config.input_dirfromfilepath1:Ntodir1:Ninparallel.parsers.parse_filepath.Type of update
This is a feature update.
Associated issues
None
Additional context
Also addresses a bug that I think I introduced with the metadata regex stuff as a deepsource fix somewhere along the way related to which pieces of the relpath are used, it was skipping the first one but I think a syntax change upstream made that the wrong thing to do. Might be evidence that it needs more specific tests.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md