Skip to content

Add to_roi to InteractiveShapes - #190

Open
joshqsumner wants to merge 6 commits into
mainfrom
add-to_roi-to-editor
Open

joshqsumner wants to merge 6 commits into
mainfrom
add-to_roi-to-editor

Conversation

@joshqsumner

Copy link
Copy Markdown
Contributor

Describe your changes
Changes to_roi to use a source argument instead of a geojson argument. This will help avoid the pattern described in #189 and seen in most of our geospatial tutorials where you convert_x to write it out to a geojson from your viewer then read the geojson in to get an ROI. Once that feature exists it let us add a method for interactiveshapes.to_roi to do the conversion directly from the viewer.

Type of update
This is a new feature.

Associated issues
Closes #189

Additional context
Will require updating tutorials, is not part of the paper, and is a breaking change.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv-geospatial/mkdocs.yml
  • Changes to function input/output signatures added to changelog.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added enhancement New feature or request breaking breaking change labels Sep 23, 2026
@deepsource-io

deepsource-io Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 0afb350...0bd2c14 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Sep 23, 2026 8:37p.m. Review ↗
Code coverage Sep 23, 2026 8:38p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
100%
Python
100%
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@joshqsumner joshqsumner changed the title Add to roi to editor Add to_roi to InteractiveShapes Sep 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking breaking change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow for InteractiveShapes layers to convert directly to ROIs

1 participant