Repository navigation
Add to_roi to InteractiveShapes - #190
Open
joshqsumner wants to merge 6 commits into
Open
joshqsumner wants to merge 6 commits into
joshqsumner wants to merge 6 commits into
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python | Sep 23, 2026 8:37p.m. | Review ↗ | |
| Code coverage | Sep 23, 2026 8:38p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 100% |
100% |
| Python | 100% |
100% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changes
to_roito use asourceargument instead of ageojsonargument. This will help avoid the pattern described in #189 and seen in most of our geospatial tutorials where youconvert_xto write it out to a geojson from your viewer then read the geojson in to get an ROI. Once that feature exists it let us add a method forinteractiveshapes.to_roito do the conversion directly from the viewer.Type of update
This is a new feature.
Associated issues
Closes #189
Additional context
Will require updating tutorials, is not part of the paper, and is a breaking change.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv-geospatial/mkdocs.ymlchangelog.md