feat: add ability to store and get progress #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds the ability to store and retrieve task execution progress for all PostgreSQL backend implementations (asyncpg, aiopg, psqlpy, and psycopg). The changes include:
- Adding
set_progress()andget_progress()methods to all result backend implementations - Updating database schemas to include a
progresscolumn - Modifying SQL queries to accommodate the new column
- Adding comprehensive integration tests for the new functionality
- Updating dependencies to their latest versions
- Removing unnecessary
from __future__ import annotationsimports across the codebase
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updated multiple dependencies including asyncpg (0.30.0→0.31.0), mypy (1.18.2→1.19.0), polyfactory (2.22.2→3.1.0), and others to their latest versions |
| tests/integration/test_result_backend.py | Added new integration tests for progress tracking functionality |
| tests/integration/test_schedule_source.py | Removed unnecessary imports and cleaned up formatting |
| tests/integration/test_broker.py | Removed conditional type checking imports |
| src/taskiq_pg/asyncpg/result_backend.py | Implemented set_progress and get_progress methods |
| src/taskiq_pg/asyncpg/queries.py | Added progress column to table schema and new SQL queries |
| src/taskiq_pg/aiopg/result_backend.py | Implemented set_progress and get_progress methods |
| src/taskiq_pg/aiopg/queries.py | Added progress column to table schema and new SQL queries |
| src/taskiq_pg/psqlpy/result_backend.py | Implemented set_progress and get_progress methods |
| src/taskiq_pg/psqlpy/queries.py | Added progress column to table schema and new SQL queries |
| src/taskiq_pg/psycopg/result_backend.py | Implemented set_progress and get_progress methods |
| src/taskiq_pg/psycopg/queries.py | Added progress column to table schema and new SQL queries |
| src/taskiq_pg/psycopg/broker.py | Removed conditional imports |
| src/taskiq_pg/psqlpy/broker.py | Removed conditional imports |
| src/taskiq_pg/_internal/result_backend.py | Removed conditional imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.