Enable linter errchkjson.

Signed-off-by: Xun Jiang <jxun@vmware.com>

golangci.yaml

@@ -327,6 +327,7 @@ linters:
     - usestdlibvars
     - whitespace
     - dupword
+    - errchkjson
   fast: false
 
 

pkg/backup/backup.go

@@ -438,8 +438,13 @@ func (kb *kubernetesBackupper) BackupWithResolvers(log logrus.FieldLogger,
 	if err := kube.PatchResource(backupRequest.Backup, updated, kb.kbClient); err != nil {
 		log.WithError(errors.WithStack((err))).Warn("Got error trying to update backup's status.progress and hook status")
 	}
-	skippedPVSummary, _ := json.Marshal(backupRequest.SkippedPVTracker.Summary())
+
+	var skippedPVSummary []byte
+	if skippedPVSummary, err = json.Marshal(backupRequest.SkippedPVTracker.Summary()); err != nil {
+		log.WithError(errors.WithStack(err)).Warn("Fail to generate skipped PV summary.")
+	}
 	log.Infof("Summary for skipped PVs: %s", skippedPVSummary)
+
 	backupRequest.Status.Progress = &velerov1api.BackupProgress{TotalItems: len(backupRequest.BackedUpItems), ItemsBackedUp: len(backupRequest.BackedUpItems)}
 	log.WithField("progress", "").Infof("Backed up a total of %d items", len(backupRequest.BackedUpItems))
 

pkg/cmd/util/output/describe.go

@@ -164,6 +164,6 @@ func (d *StructuredDescriber) JSONEncode() string {
 	encoder := json.NewEncoder(byteBuffer)
 	encoder.SetEscapeHTML(false)
 	encoder.SetIndent("", "    ")
-	_ = encoder.Encode(d.output)
+	encoder.Encode(d.output)
 	return byteBuffer.String()
 }

pkg/controller/backup_deletion_controller.go

@@ -544,7 +544,10 @@ func (r *backupDeletionReconciler) deleteMovedSnapshots(ctx context.Context, bac
 	for i := range list.Items {
 		cm := list.Items[i]
 		snapshot := repository.SnapshotIdentifier{}
-		b, _ := json.Marshal(cm.Data)
+		b, err := json.Marshal(cm.Data)
+		if err != nil {
+			r.logger.WithError(err).Infof("Fail to encode JSON: %v", cm.Data)
+		}
 		if err := json.Unmarshal(b, &snapshot); err != nil {
 			errs = append(errs, errors.Wrapf(err, "failed to unmarshal snapshot info"))
 			continue

pkg/datamover/dataupload_delete_action.go

@@ -58,9 +58,12 @@ func genConfigmap(bak *velerov1.Backup, du velerov2alpha1.DataUpload) *corev1api
 		SnapshotID:            du.Status.SnapshotID,
 		RepositoryType:        GetUploaderType(du.Spec.DataMover),
 	}
-	b, _ := json.Marshal(snapshot)
+	b, err := json.Marshal(snapshot)
+	if err != nil {
+		return nil
+	}
 	data := make(map[string]string)
-	_ = json.Unmarshal(b, &data)
+	json.Unmarshal(b, &data)
 	return &corev1api.ConfigMap{
 		TypeMeta: metav1.TypeMeta{
 			APIVersion: corev1api.SchemeGroupVersion.String(),