Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
  • Loading branch information
baronfel and rainersigwald authored Jan 24, 2023
1 parent 9910ce0 commit 509240d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DEVGUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ To use your locally built packages:

## Using the package when implicit SDK support is enabled

If you are on SDK 7.0.2xx or greater, are a Web SDK project, and have `EnableSdkContainerSupport` set to `true` in your project file, you will need to use another mechanism to reference the generated package. You can do one of the following actions:
If you are on SDK 7.0.200 or greater, are a Web SDK project, and have `EnableSdkContainerSupport` set to `true` in your project file, you will need to use another mechanism to reference the generated package. You can do one of the following actions:

* Set `EnableSdkContainerSupport` to `false` in your project file and use a normal PackageReference as described above,
* Keep `EnableSdkContainerSupport` set to `true` and set the `SdkContainerSupportPackageVersion` property to the version you built above,
Expand Down
2 changes: 1 addition & 1 deletion docs/ContainerCustomization.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ By default, if your project has a RuntimeIdentifier set, that value will be used
```

> **Note**
> If you'd like to publish to a musl-based OS like alpine (as opposed to a libc-based OS), you will need to specify the base image _exactly_, instead of relying on
> If you'd like to publish to a musl-based OS like alpine (as opposed to a libc-based OS), you will need to specify the base image _including architecture_, instead of relying on
> any of the inference described above. For example, a `net7.0`-targeting application that wanted to run on alpine with the x64 architecture would use the `7.0-alpine-amd64` tag of the `mcr.microsoft.com/dotnet/runtime` image (or another base image as appropriate for your project type):
>
> ```xml
Expand Down

0 comments on commit 509240d

Please sign in to comment.