Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded mark to fixture #221

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

candleindark
Copy link
Member

Applying a mark to a fixture function never had any affect. It now issues a warning in Pytest V8 and will raise an error in the future version of Pytest. For details, please check out https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function.

Merging this PR is necessary for future PRs to pass the needed tests.

Applying a mark to a fixture function never had
any affect. It now issues a warning in Pytest V8
and will raise an error in the future version of
Pytest. For details, please check out
https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
@candleindark candleindark requested a review from jwodder January 30, 2024 20:14
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbd704a) 97.66% compared to head (b8dfbec) 91.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   97.66%   91.99%   -5.68%     
==========================================
  Files          18       18              
  Lines        1799     1798       -1     
==========================================
- Hits         1757     1654     -103     
- Misses         42      144     +102     
Flag Coverage Δ
unittests 91.99% <ø> (-5.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic added internal Changes only affect the internal API tests Add or improve existing tests and removed internal Changes only affect the internal API labels Jan 30, 2024
@yarikoptic yarikoptic merged commit 4423b41 into dandi:master Jan 30, 2024
37 of 47 checks passed
@candleindark candleindark deleted the no-mark-to-fixture branch January 30, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants