Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typing_extensions imports #207

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Remove typing_extensions imports #207

merged 1 commit into from
Dec 8, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Dec 8, 2023

These are unneeded now that dandischema only supports Python 3.8.

@jwodder jwodder added the internal Changes only affect the internal API label Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68f4d1e) 97.61% compared to head (cd82222) 97.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   97.61%   97.71%   +0.10%     
==========================================
  Files          17       17              
  Lines        1760     1752       -8     
==========================================
- Hits         1718     1712       -6     
+ Misses         42       40       -2     
Flag Coverage Δ
unittests 97.71% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder requested a review from satra December 8, 2023 13:31
@yarikoptic yarikoptic merged commit 7610edb into master Dec 8, 2023
@yarikoptic yarikoptic deleted the no-typing-ext branch December 8, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants