-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: adding datacite validation #181
Conversation
for more information, see https://pre-commit.ci
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 97.71% 92.29% -5.43%
==========================================
Files 17 17
Lines 1751 1751
==========================================
- Hits 1711 1616 -95
- Misses 40 135 +95
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
dandi_id = f"DANDI:{dandi_id_noprefix}" | ||
version = "0.0.0" | ||
version = f"0.0.{random.randrange(0, 9999)}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of random, perhaps use the current date+time in some form.
i think it would be good to limit the publishing test to only the platform that dandiarchive uses, so we don't have to test it for all options and limit the number of published dois on the test site. |
@satra - you mean just to use for one of the linux containers we have, not adding a new one that is the same as dandiarchive uses, right? |
yes, one of the containers that matches the dandiarchive deployment. we should ask @mvandenburgh - how we can make sure to always have a setting that's as close to, if not identical, to the deployment versions on heroku. |
closing this since #167 was merged. |
added
publish=True
to one test to enable datacite validation. The doi will be published on https://doi.test.datacite.org/ as Findable, so will not be able to remove it!I'm creating
doi
withid = 000002
and randomversion = 0.0.{random.randrange(0, 9999)}