Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit hooks and rerun #145

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Update pre-commit hooks and rerun #145

merged 1 commit into from
Oct 6, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 6, 2022

This addresses a fatal problem with an older version of black using a now-removed private part of click.

@jwodder jwodder added the internal Changes only affect the internal API label Oct 6, 2022
@yarikoptic
Copy link
Member

I have merged #146 which is what I guess made it all red here, @jwodder please update/rerun .

@jwodder jwodder force-pushed the update-pre-commit branch from f575653 to a1cb0df Compare October 6, 2022 18:32
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 96.61% // Head: 96.61% // No change to project coverage 👍

Coverage data is based on head (a1cb0df) compared to base (0642881).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          16       16           
  Lines        1623     1623           
=======================================
  Hits         1568     1568           
  Misses         55       55           
Flag Coverage Δ
unittests 96.61% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/exceptions.py 100.00% <ø> (ø)
dandischema/tests/test_datacite.py 100.00% <ø> (ø)
dandischema/datacite.py 95.45% <100.00%> (ø)
dandischema/digests/dandietag.py 94.81% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jwodder
Copy link
Member Author

jwodder commented Oct 6, 2022

@yarikoptic Rebased.

@yarikoptic
Copy link
Member

Looks good to me and non-functional changes, so to avoid conflicts via delaying I am merging now.

@yarikoptic yarikoptic merged commit e7a1975 into master Oct 6, 2022
@yarikoptic yarikoptic deleted the update-pre-commit branch October 6, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants