Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 0.6.2 to validation schemas #133

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Conversation

satra
Copy link
Member

@satra satra commented Apr 26, 2022

adds missing schema to validation logic

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #133 (dec0419) into master (6e99462) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   96.67%   96.67%           
=======================================
  Files          18       18           
  Lines        1654     1654           
=======================================
  Hits         1599     1599           
  Misses         55       55           
Flag Coverage Δ
unittests 96.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/consts.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e99462...dec0419. Read the comment docs.

@satra satra added minor Increment the minor version when merged release Create a release when this pr is merged labels Apr 26, 2022
@yarikoptic
Copy link
Member

Just to make sure -- it is not to mitigate dandi/dandi-cli#987 (comment) right?

@satra
Copy link
Member Author

satra commented Apr 27, 2022

nope, but this is a bug.

@yarikoptic
Copy link
Member

@satra are you sure you want minor release (thus making it 0.8.0) instead of just a patch (making it 0.7.1). IMHO should be a patch

@yarikoptic yarikoptic added patch Increment the patch version when merged and removed minor Increment the minor version when merged labels Apr 28, 2022
@yarikoptic
Copy link
Member

changing to patch, merging

@yarikoptic yarikoptic merged commit a548270 into master Apr 28, 2022
@yarikoptic yarikoptic deleted the fix/validation_schemas branch April 28, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants