Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove size comparison check when uploading Zarr entries #986

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 26, 2022

In order to cut down on (likely superfluous) API requests.

As discussed in Jitsi today.

@jwodder jwodder added performance Improve performance of an existing feature cmd-upload zarr labels Apr 26, 2022
@yarikoptic yarikoptic added the release Create a release when this pr is merged label Apr 26, 2022
@yarikoptic
Copy link
Member

Looks LGTM -- let's wait for tests to pass

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #986 (bd2325f) into master (30446b8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #986      +/-   ##
==========================================
+ Coverage   87.45%   87.50%   +0.04%     
==========================================
  Files          64       64              
  Lines        8109     8106       -3     
==========================================
+ Hits         7092     7093       +1     
+ Misses       1017     1013       -4     
Flag Coverage Δ
unittests 87.50% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/files.py 78.54% <100.00%> (-0.12%) ⬇️
dandi/dandiapi.py 88.14% <0.00%> (-0.14%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30446b8...bd2325f. Read the comment docs.

@yarikoptic yarikoptic merged commit 5154ca3 into master Apr 26, 2022
@yarikoptic yarikoptic deleted the rm-size-cmp branch April 26, 2022 18:18
@github-actions
Copy link

🚀 PR was released in 0.39.4 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd-upload performance Improve performance of an existing feature release Create a release when this pr is merged released zarr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants