Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full asset path as name of Zarr object #912

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 16, 2022

@jwodder jwodder added the patch Increment the patch version when merged label Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #912 (ee73478) into master (533eeb9) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
- Coverage   86.82%   86.79%   -0.03%     
==========================================
  Files          61       61              
  Lines        7424     7424              
==========================================
- Hits         6446     6444       -2     
- Misses        978      980       +2     
Flag Coverage Δ
unittests 86.79% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/files.py 79.82% <ø> (ø)
dandi/download.py 86.96% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533eeb9...ee73478. Read the comment docs.

@yarikoptic
Copy link
Member

ok, let's see if that would help dandi-archive anyhow. Thank you @jwodder

@yarikoptic yarikoptic merged commit 0e6c5ef into master Feb 16, 2022
@yarikoptic yarikoptic deleted the zarr-path-name branch February 16, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants