Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show valid instance names when given a dandi:// URL with an unknown instance #815

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 25, 2021

Closes #809.

@jwodder jwodder added the patch Increment the patch version when merged label Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #815 (aab3af5) into master (bc93b64) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
+ Coverage   84.56%   84.63%   +0.06%     
==========================================
  Files          61       61              
  Lines        6161     6168       +7     
==========================================
+ Hits         5210     5220      +10     
+ Misses        951      948       -3     
Flag Coverage Δ
unittests 84.63% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiarchive.py 85.35% <100.00%> (+1.76%) ⬆️
dandi/tests/test_dandiarchive.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc93b64...aab3af5. Read the comment docs.

@yarikoptic
Copy link
Member

Looks great to me, thank you @jwodder . In the future (if happens) we might relax the test a bit to not list all possible instances in the expected string, or code that list up since it would be annoying to dig out / adjust that test every time we need to add or remove an instance

@yarikoptic yarikoptic merged commit cbb5306 into master Oct 25, 2021
@yarikoptic yarikoptic deleted the gh-809 branch October 25, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List available instances whenever provided dandi:// url points to some incorrectly specified one
2 participants