Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replace_asset parameter to iter_upload_raw_asset() #743

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 27, 2021

Closes #736.

@jwodder jwodder added the minor Increment the minor version when merged label Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #743 (bdb6179) into master (dd1ce9c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   84.84%   84.83%   -0.01%     
==========================================
  Files          59       59              
  Lines        5977     5975       -2     
==========================================
- Hits         5071     5069       -2     
  Misses        906      906              
Flag Coverage Δ
unittests 84.83% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 93.09% <100.00%> (-0.03%) ⬇️
dandi/upload.py 83.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1ce9c...bdb6179. Read the comment docs.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Jul 27, 2021
@yarikoptic
Copy link
Member

if all is good, let's also release so any testing against released version of dandi-cli is not suffering

@yarikoptic
Copy link
Member

green now (besides codecov) - let's proceed

@yarikoptic yarikoptic merged commit 216cccf into master Jul 28, 2021
@yarikoptic yarikoptic deleted the gh-736 branch July 28, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli trying to upload blob that exists
2 participants