Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move schema code to dandischema #643

Merged
merged 1 commit into from
May 20, 2021
Merged

Move schema code to dandischema #643

merged 1 commit into from
May 20, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented May 20, 2021

Closes #638.

This PR is pending a release of dandischema (now done).

@jwodder jwodder added the minor Increment the minor version when merged label May 20, 2021
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #643 (8f657ab) into master (ac06349) will decrease coverage by 0.85%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
- Coverage   84.24%   83.39%   -0.86%     
==========================================
  Files          61       58       -3     
  Lines        5822     5196     -626     
==========================================
- Hits         4905     4333     -572     
+ Misses        917      863      -54     
Flag Coverage Δ
unittests 83.39% <84.61%> (-0.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/cmd_ls.py 66.46% <0.00%> (ø)
dandi/consts.py 100.00% <ø> (ø)
dandi/validate.py 53.57% <50.00%> (ø)
dandi/dandiset.py 84.21% <100.00%> (ø)
dandi/metadata.py 67.98% <100.00%> (-6.53%) ⬇️
dandi/tests/test_metadata.py 100.00% <100.00%> (ø)
dandi/tests/test_validate.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac06349...8f657ab. Read the comment docs.

@jwodder jwodder marked this pull request as ready for review May 20, 2021 16:05
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a meticulous amputation, nicely done @jwodder ;-) Haven't spotted any gotcha

@yarikoptic
Copy link
Member

Let's proceed and hope for the bright future!

@yarikoptic yarikoptic merged commit 81045b2 into master May 20, 2021
@yarikoptic yarikoptic deleted the gh-638 branch May 20, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move metadata functionality to a dedicated dandischema
2 participants