Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dandi-staging to known_instances #621

Merged
merged 1 commit into from
May 7, 2021
Merged

Conversation

dchiquito
Copy link
Contributor

There is now a staging API server set up at https://api-staging.dandiarchive.org, so it would be cool if dandi-cli could upload to it.

@dchiquito dchiquito requested review from yarikoptic and jwodder May 7, 2021 21:25
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #621 (86e9b1e) into master (0dabaf4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #621   +/-   ##
=======================================
  Coverage   83.89%   83.89%           
=======================================
  Files          59       59           
  Lines        5701     5701           
=======================================
  Hits         4783     4783           
  Misses        918      918           
Flag Coverage Δ
unittests 83.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/consts.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dabaf4...86e9b1e. Read the comment docs.

@yarikoptic
Copy link
Member

sweet, didn't try it but let's proceed.

BTW, we left

    "dandi-devel": dandi_instance(
        "https://gui-beta-dandiarchive-org.netlify.app",
        None,
        None,
    ),

in place -- is that web ui instance ever to come back or should we kill it?

@yarikoptic yarikoptic added the patch Increment the patch version when merged label May 7, 2021
@yarikoptic yarikoptic merged commit a3b6a6b into master May 7, 2021
@yarikoptic yarikoptic deleted the staging-instance branch May 7, 2021 21:50
@yarikoptic yarikoptic added the enhancement New feature or request label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants