Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: organize - should no longer alter dandiset.yaml #615

Merged
merged 1 commit into from
May 6, 2021

Conversation

yarikoptic
Copy link
Member

We will just rely on users to populate it online without providing them
with any assistance locally since we do not upload dandiset.yaml
anyways.

Discussion/observation which triggered this change: #614 (comment)

We will just rely on users to populate it online without providing them
with any assistance locally since we do not upload dandiset.yaml
anyways.

Discussion/observation which triggered this change: #614 (comment)
@yarikoptic yarikoptic added the minor Increment the minor version when merged label May 6, 2021
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #615 (46dbe88) into master (0288e6a) will decrease coverage by 0.20%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
- Coverage   84.10%   83.89%   -0.21%     
==========================================
  Files          59       59              
  Lines        5717     5701      -16     
==========================================
- Hits         4808     4783      -25     
- Misses        909      918       +9     
Flag Coverage Δ
unittests 83.89% <50.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_organize.py 93.60% <ø> (ø)
dandi/cli/cmd_organize.py 76.87% <50.00%> (-0.43%) ⬇️
dandi/organize.py 85.76% <0.00%> (-6.54%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0288e6a...46dbe88. Read the comment docs.

@yarikoptic
Copy link
Member Author

thank you @jwodder for the review, let's proceed

@yarikoptic yarikoptic merged commit 0dabaf4 into master May 6, 2021
@yarikoptic yarikoptic deleted the rf-organize branch May 6, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants