-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying the dandi redirector via an env var #581
Conversation
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
==========================================
+ Coverage 83.08% 83.20% +0.11%
==========================================
Files 59 59
Lines 5681 5685 +4
==========================================
+ Hits 4720 4730 +10
+ Misses 961 955 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Note: When I run the tests with |
I guess we should still have this one finished up and whatever connection issue is figured out and proceed, right? |
e5b8e69
to
04b428c
Compare
@yarikoptic Merge conflicts resolved; this PR should be ready now. The connection issue was resolved by dandi/redirector#45. After this PR is published in a release, dandi/redirector#47 can be merged. |
well, to not hold off other PRs, let's merge and release then! |
For dandi/redirector#42.