Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying the dandi redirector via an env var #581

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 19, 2021

@jwodder jwodder added the internal Changes only affect the internal API label Apr 19, 2021
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #581 (04b428c) into master (914a9cf) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
+ Coverage   83.08%   83.20%   +0.11%     
==========================================
  Files          59       59              
  Lines        5681     5685       +4     
==========================================
+ Hits         4720     4730      +10     
+ Misses        961      955       -6     
Flag Coverage Δ
unittests 83.20% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/fixtures.py 97.12% <ø> (ø)
dandi/consts.py 100.00% <100.00%> (ø)
dandi/tests/test_dandiarchive.py 100.00% <100.00%> (ø)
dandi/tests/test_utils.py 100.00% <100.00%> (ø)
dandi/download.py 87.65% <0.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 914a9cf...04b428c. Read the comment docs.

@jwodder
Copy link
Member Author

jwodder commented Apr 19, 2021

Note: When I run the tests with DANDI_REDIRECTOR_BASE=http://localhost:8079, everything succeeds except for test_utils.py::test_server_info, which keeps getting a "connection refused" error.

@yarikoptic
Copy link
Member

I guess we should still have this one finished up and whatever connection issue is figured out and proceed, right?

@jwodder
Copy link
Member Author

jwodder commented Apr 30, 2021

@yarikoptic Merge conflicts resolved; this PR should be ready now. The connection issue was resolved by dandi/redirector#45. After this PR is published in a release, dandi/redirector#47 can be merged.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Apr 30, 2021
@yarikoptic
Copy link
Member

well, to not hold off other PRs, let's merge and release then!

@yarikoptic yarikoptic merged commit 8852a31 into master Apr 30, 2021
@yarikoptic yarikoptic deleted the redirector-envvar branch April 30, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants