Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for the version /info endpoint in dandi-api #575

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

dchiquito
Copy link
Contributor

Required by dandi/dandi-archive#236

As described in dandi/dandi-archive#236, the
original .../versions/{version_id}/ has been updated to only return
the version metadata. Because clients are still relying on the Django
serialized information about the version, that data can now be found at
.../versions/{version_id}/info/.

As described in dandi/dandi-archive#236, the
original `.../versions/{version_id}/` has been updated to only return
the version metadata. Because clients are still relying on the Django
serialized information about the version, that data can now be found at
`.../versions/{version_id}/info/`.
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #575 (0ed2ad5) into master (87c30e2) will decrease coverage by 19.66%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #575       +/-   ##
===========================================
- Coverage   83.73%   64.06%   -19.67%     
===========================================
  Files          62       62               
  Lines        6596     6596               
===========================================
- Hits         5523     4226     -1297     
- Misses       1073     2370     +1297     
Flag Coverage Δ
unittests 64.06% <ø> (-19.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 19.84% <ø> (-68.10%) ⬇️
dandi/tests/test_dandiapi.py 12.24% <0.00%> (-87.76%) ⬇️
dandi/upload.py 2.37% <0.00%> (-73.40%) ⬇️
dandi/tests/test_upload.py 19.27% <0.00%> (-72.92%) ⬇️
dandi/tests/test_delete.py 27.20% <0.00%> (-72.80%) ⬇️
dandi/support/generatorify.py 0.00% <0.00%> (-64.37%) ⬇️
dandi/conftest.py 38.46% <0.00%> (-61.54%) ⬇️
dandi/tests/test_register.py 41.17% <0.00%> (-58.83%) ⬇️
dandi/delete.py 38.34% <0.00%> (-58.65%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c30e2...0ed2ad5. Read the comment docs.

@satra
Copy link
Member

satra commented Apr 16, 2021

@dchiquito - is this temporary for now?

@dchiquito
Copy link
Contributor Author

@satra Yes, it is there to avoid rewriting substantial chunks of both clients. With this in place we can refactor at our leisure.

@yarikoptic
Copy link
Member

ok, merging and releasing. Note: as tests here fail since we do not use dandi-api from that PR, future RFing of API would be trickier since dandi-cli will be released/in production, so we would need to provide "deprecation" cycle of some kind for the /info endpoint if it is to be gone

@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels Apr 16, 2021
@yarikoptic yarikoptic changed the title Update the version info endpoint Update for the version /info endpoint in dandi-api Apr 16, 2021
@yarikoptic yarikoptic merged commit b8e7c1c into master Apr 16, 2021
@yarikoptic yarikoptic deleted the version-metadata-endpoint branch April 16, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants