Remove "current" column from upload progress display #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
=======================================
Coverage 64.91% 64.91%
=======================================
Files 59 59
Lines 5991 5991
=======================================
Hits 3889 3889
Misses 2102 2102
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yarikoptic
approved these changes
Mar 23, 2021
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Closed
|
Thank you @jwodder for the PR and a detailed description. Let's release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading to the new API, when the code actually reaches the point at which the upload proper happens, a "CURRENT" column appears at the right side of the pyout display containing the current number of bytes uploaded per file. As this column is not declared in the list passed to the pyout table constructor, I assume it is not supposed to be displayed in the first place. This PR removes the "current" field from the upload progress dict before yielding it to pyout, which should get rid of the column.