Display dandi validate errors using logger

[jwodder]

Closes #458.

[codecov]

Codecov Report

Merging #459 (e9d7e97) into master (7e6464a) will increase coverage by 0.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   82.29%   82.34%   +0.05%     
==========================================
  Files          55       55              
  Lines        5744     5790      +46     
==========================================
+ Hits         4727     4768      +41     
- Misses       1017     1022       +5     

Flag	Coverage Δ
unittests	82.34% <50.00%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dandi/cli/cmd_validate.py	82.35% <50.00%> (-5.15%)	⬇️
dandi/dandiapi.py	88.12% <0.00%> (+0.95%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6464a...e9d7e97. Read the comment docs.

[yarikoptic]

thank you @jwodder , let it be like this for now. validation is yet to be RFed later on (#431 etc), so we will tune later

[djarecka]

thanks for addressing my issue. Unfortunately, the output is now much less readable IMO

before:

after:

Let me know if you want me to open a separate issue.

[jwodder]

@yarikoptic What exactly should the output look like?

[yarikoptic]

IMHO it is ok (although not colored) -- the only thing is that %s: ok I have missed - somewhere path was not provided.
Or @djarecka what readability aspect you have in mind?

[jwodder]

@yarikoptic I fixed the "%s: ok" thing in #462.

[djarecka]

@yarikoptic - it doesn't provide info about files that are not failing, and yes the color also helps

[djarecka]

@jwodder - thanks, your PR helps! The color is gone, but I guess, we can live with this.

[yarikoptic]

yes, let's live without colors for now. Later we will RF for more consistent handling of outputs etc and I hope that is when colors would return ;-)