Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DandiMeta to DandisetMeta #454

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Rename DandiMeta to DandisetMeta #454

merged 1 commit into from
Mar 9, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 5, 2021

Closes #453.

The test failures are due to changes caused by dandi/dandi-archive#144. The fix for them is in #452. After that PR is merged, I will rebase this PR and then un-draft it.

After merging this PR, merge dandi/dandi-api-datasets#20.

@jwodder jwodder added the patch Increment the patch version when merged label Mar 5, 2021
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #454 (b714908) into master (cbdd48f) will increase coverage by 0.05%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   82.24%   82.29%   +0.05%     
==========================================
  Files          55       55              
  Lines        5744     5744              
==========================================
+ Hits         4724     4727       +3     
+ Misses       1020     1017       -3     
Flag Coverage Δ
unittests 82.29% <70.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/cmd_ls.py 60.73% <0.00%> (ø)
dandi/validate.py 59.42% <0.00%> (ø)
dandi/metadata.py 77.44% <100.00%> (ø)
dandi/models.py 86.19% <100.00%> (ø)
dandi/tests/test_metadata.py 100.00% <100.00%> (ø)
dandi/tests/test_models.py 100.00% <100.00%> (ø)
dandi/upload.py 76.38% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 902a020...b714908. Read the comment docs.

@jwodder jwodder marked this pull request as ready for review March 8, 2021 20:17
@yarikoptic
Copy link
Member

Thank you! Let's proceed

@yarikoptic yarikoptic merged commit 7e6464a into master Mar 9, 2021
@yarikoptic yarikoptic deleted the gh-453 branch March 9, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schema: *DandiMeta -> *DandisetMeta
2 participants