Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify release workflow #444

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Simplify release workflow #444

merged 1 commit into from
Mar 1, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 1, 2021

This eliminates the use of auto version (a failure in which led to a failed & unsolicited attempt at uploading to PyPI) in favor of triggering the build & upload via auto's exec plugin and its afterRelease hook.

@jwodder jwodder added the internal Changes only affect the internal API label Mar 1, 2021
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #444 (76f4ab4) into master (1affad9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files          55       55           
  Lines        5664     5664           
=======================================
  Hits         4664     4664           
  Misses       1000     1000           
Flag Coverage Δ
unittests 82.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1affad9...76f4ab4. Read the comment docs.

@yarikoptic
Copy link
Member

not verse in auto enough to review. If works (or you think @jwodder it should work) -- good with me

@jwodder
Copy link
Member Author

jwodder commented Mar 1, 2021

@yarikoptic This setup has already been used for releases of datalad-installer and fscacher, and I've tested it in a test repository. It works.

@yarikoptic yarikoptic merged commit 1a47bc8 into master Mar 1, 2021
@yarikoptic yarikoptic deleted the simplify-release branch March 1, 2021 20:30
@yarikoptic
Copy link
Member

Thank you @jwodder !

@jwodder jwodder added the release automation Automatic release and changelog generation label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API release automation Automatic release and changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants