Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report dandi version in User-Agent header #424

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Report dandi version in User-Agent header #424

merged 1 commit into from
Feb 25, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 25, 2021

This PR sets a User-Agent header when communicating with the new API that contains the version of dandi in use.

@jwodder jwodder added the patch Increment the patch version when merged label Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #424 (ece44bd) into master (1cc2043) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #424   +/-   ##
=======================================
  Coverage   82.25%   82.25%           
=======================================
  Files          55       55           
  Lines        5679     5681    +2     
=======================================
+ Hits         4671     4673    +2     
  Misses       1008     1008           
Flag Coverage Δ
unittests 82.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 87.34% <100.00%> (+0.05%) ⬆️
dandi/utils.py 75.83% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc2043...ece44bd. Read the comment docs.

@yarikoptic
Copy link
Member

GREAT IDEA! Thank you @jwodder !

@yarikoptic yarikoptic merged commit 5d1d8a8 into master Feb 25, 2021
@yarikoptic yarikoptic deleted the user-agent branch February 25, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants