Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #409 (Content-MD5 header) #419

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Revert PR #409 (Content-MD5 header) #419

merged 2 commits into from
Feb 23, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 23, 2021

See this comment and dchiquito's response

This reverts commit cdba8e2, reversing
changes made to 574aced.
@jwodder jwodder added the patch Increment the patch version when merged label Feb 23, 2021
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #419 (8227e71) into master (a6d290a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
- Coverage   82.31%   82.28%   -0.03%     
==========================================
  Files          55       55              
  Lines        5693     5674      -19     
==========================================
- Hits         4686     4669      -17     
+ Misses       1007     1005       -2     
Flag Coverage Δ
unittests 82.28% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_dandiapi.py 100.00% <ø> (ø)
dandi/dandiapi.py 88.31% <100.00%> (-0.58%) ⬇️
dandi/upload.py 75.93% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d290a...8227e71. Read the comment docs.

@yarikoptic
Copy link
Member

eh, ok -- so it seems we cannot do this additional upload integrity/validation checking without informing the api-server about those per each chunk since it is the one which is to mint those urls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants