Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: allow to handle an item with multiple files #342

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

yarikoptic
Copy link
Member

How that happened, nobody knows. But since we are making judgement anyways
only on the metadata in the item, we will just allow to remove the entire item
and reupload that file

attn @CodyCBakerPhD

How that happened, nobody knows.  But since we are making judgement anyways
only on the metadata in the item, we will just allow to remove the entire item
and reupload that file
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #342 (2ad80e0) into master (30e0695) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   81.78%   81.81%   +0.03%     
==========================================
  Files          55       55              
  Lines        5341     5341              
==========================================
+ Hits         4368     4370       +2     
+ Misses        973      971       -2     
Flag Coverage Δ
unittests 81.81% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/upload.py 69.48% <66.66%> (ø)
dandi/dandiapi.py 85.00% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e0695...2ad80e0. Read the comment docs.

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Jan 26, 2021
@CodyCBakerPhD
Copy link
Contributor

@yarikoptic Yep, this worked! Those files are now uploaded, thanks.

@yarikoptic yarikoptic merged commit 0b9e79f into master Feb 1, 2021
@yarikoptic yarikoptic deleted the bf-upload-multifile-item branch February 1, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants