Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: add h5py.__version__ into the list of tokens for caching #284

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

yarikoptic
Copy link
Member

h5py 3.0 introduced breaking changes (see e.g. #282)
and hdmf yet to account for them. We better cache that version too to improve
consistency of outputs etc

h5py 3.0 introduced breaking changes (see e.g. #282)
and hdmf yet to account for them.  We better cache that version too to improve
consistency of outputs etc
@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels Nov 25, 2020
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #284 (142e21e) into master (39c62bc) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   82.42%   82.34%   -0.09%     
==========================================
  Files          54       54              
  Lines        4598     4598              
==========================================
- Hits         3790     3786       -4     
- Misses        808      812       +4     
Flag Coverage Δ
unittests 82.34% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/pynwb_utils.py 86.16% <100.00%> (ø)
dandi/cli/cmd_organize.py 77.30% <0.00%> (-2.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39c62bc...142e21e. Read the comment docs.

@yarikoptic yarikoptic merged commit 1974553 into master Dec 1, 2020
@yarikoptic yarikoptic deleted the bf-h5py-ver-token branch December 1, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant