-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use oldest file when race condition causes multiple files per item #265
Conversation
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 81.04% 81.02% -0.02%
==========================================
Files 52 52
Lines 4362 4363 +1
==========================================
Hits 3535 3535
- Misses 827 828 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and didn't break any test, so good to go - merge whenever we are ready to "auto-release". I meanwhile will try it on drogon
@yarikoptic Oops — I merged this, but forgot that #257 wasn't merged yet (It is now). Is there another quick PR we could merge to try out a release? |
nothing comes to mind... I guess there should be some provisioning for that with this setup to just trigger a release from current master? if not -- just make some nonimportant PR (some tune up to formatting of CHANGELOG or README or whatnot) |
@yarikoptic PR made and release triggered successfully! |
whoohoo -- I see 0.7.1 on https://pypi.org/project/dandi/ ! |
and a nice CHANGELOG! awesome. |
@yarikoptic PRs without labels default to the "Bug Fix" category, though I believe it can be changed to a different category. Is that what you're asking? |
I thought: would be nice if bot reported "failed" state (so people do not merge) for the PR until some needed label(s) were added (something like WIP bot does if there is a label WIP present) |
@yarikoptic It doesn't do that. Searching a bit, the only thing I can find that does do that is dimagi/required-labels, which we would have to host somewhere ourselves. |
ok, let's just look after each other to not forget proper labeling |
Fixes #264.