Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use oldest file when race condition causes multiple files per item #265

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 5, 2020

Fixes #264.

@jwodder jwodder added the patch Increment the patch version when merged label Nov 5, 2020
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #265 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   81.04%   81.02%   -0.02%     
==========================================
  Files          52       52              
  Lines        4362     4363       +1     
==========================================
  Hits         3535     3535              
- Misses        827      828       +1     
Flag Coverage Δ
unittests 81.02% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/girder.py 82.10% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f424a31...3e93250. Read the comment docs.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and didn't break any test, so good to go - merge whenever we are ready to "auto-release". I meanwhile will try it on drogon

@jwodder jwodder added the release Create a release when this pr is merged label Nov 5, 2020
@jwodder jwodder merged commit da60edf into master Nov 5, 2020
@jwodder jwodder deleted the gh-264 branch November 5, 2020 20:40
@jwodder
Copy link
Member Author

jwodder commented Nov 5, 2020

@yarikoptic Oops — I merged this, but forgot that #257 wasn't merged yet (It is now). Is there another quick PR we could merge to try out a release?

@yarikoptic
Copy link
Member

nothing comes to mind... I guess there should be some provisioning for that with this setup to just trigger a release from current master? if not -- just make some nonimportant PR (some tune up to formatting of CHANGELOG or README or whatnot)

@jwodder
Copy link
Member Author

jwodder commented Nov 5, 2020

@yarikoptic PR made and release triggered successfully!

@yarikoptic
Copy link
Member

whoohoo -- I see 0.7.1 on https://pypi.org/project/dandi/ !

@yarikoptic
Copy link
Member

and a nice CHANGELOG! awesome.
I wonder -- could we make sure that no PR is unlabeled "properly"? or is that already done?

@jwodder
Copy link
Member Author

jwodder commented Nov 5, 2020

@yarikoptic PRs without labels default to the "Bug Fix" category, though I believe it can be changed to a different category. Is that what you're asking?

@yarikoptic
Copy link
Member

I thought: would be nice if bot reported "failed" state (so people do not merge) for the PR until some needed label(s) were added (something like WIP bot does if there is a label WIP present)

@jwodder
Copy link
Member Author

jwodder commented Nov 6, 2020

@yarikoptic It doesn't do that. Searching a bit, the only thing I can find that does do that is dimagi/required-labels, which we would have to host somewhere ourselves.

@yarikoptic
Copy link
Member

ok, let's just look after each other to not forget proper labeling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

race between upload and download leads to a crash
2 participants