-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C elegans #1276
C elegans #1276
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1276 +/- ##
==========================================
- Coverage 89.00% 88.97% -0.03%
==========================================
Files 76 76
Lines 9793 9804 +11
==========================================
+ Hits 8716 8723 +7
- Misses 1077 1081 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I am working on an extension to support optophysiology experiments in C Elegans. The extension seems to be working well and I am hoping to upload datasets to DANDI very soon, so it would be very helpful for DANDI to have support for C Elegans species quickly. This is an effort to help facilitate data sharing across a few labs, so I know this change would be helpful to a lot of people in the worm community. |
dandi/metadata.py
Outdated
@@ -526,6 +526,12 @@ def extract_cellLine(metadata: dict) -> Optional[str]: | |||
"http://purl.obolibrary.org/obo/NCBITaxon_7955", | |||
"Danio rerio - Zebra fish", | |||
), | |||
( | |||
["c. elegans", "Caenorhabditis elegans"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the first one with a capital letter in alternative names.
Looking at https://github.com/dandi/dandi-cli/blob/HEAD/dandi/metadata.py#L598 we need
["c. elegans", "Caenorhabditis elegans"], | |
["c. elegans", "caenorhabditis elegans"], |
But also I think we better also add .lower()
there to key
(this value) to altogether ignore case , will do both now for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, if no surprises from CI - let's merge
🚀 PR was released in |
Add support for C. elegans