-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate: resolved issues with relative path input #1260
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1260 +/- ##
=======================================
Coverage 88.99% 88.99%
=======================================
Files 76 76
Lines 9784 9789 +5
=======================================
+ Hits 8707 8712 +5
Misses 1077 1077
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@jwodder incorporated your change. Can we merge now? |
please add a test which does just what you did to demonstrate the issue -- runs grep for Otherwise, without a test, there is no guarantee that we would not "fix it back" some time. Starting a fix with a reproducer test is a good habbit to have IMHO. |
Co-authored-by: John T. Wodder II <jwodder@users.noreply.github.com>
@yarikoptic done. |
🚀 PR was released in |
This is what could happen before this: