Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed logic and commented a temporarily broken BIDS (lacking README) dataset #1148

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

TheChymera
Copy link
Contributor

Error fixed upstream but it was the specification schema rather than the example data which was broken, so we won't have access to it until the new release; removing test dataset from whitelist until then.

@jwodder jwodder added the tests Add or improve existing tests label Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 88.14% // Head: 88.27% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (01640ef) compared to base (48a222f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
+ Coverage   88.14%   88.27%   +0.13%     
==========================================
  Files          73       73              
  Lines        8727     8800      +73     
==========================================
+ Hits         7692     7768      +76     
+ Misses       1035     1032       -3     
Flag Coverage Δ
unittests 88.27% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/fixtures.py 98.19% <ø> (ø)
dandi/tests/test_validate.py 100.00% <100.00%> (ø)
dandi/validate.py 97.72% <0.00%> (-2.28%) ⬇️
dandi/tests/test_files.py 100.00% <0.00%> (ø)
dandi/cli/tests/test_digest.py 100.00% <0.00%> (ø)
dandi/download.py 88.04% <0.00%> (+0.04%) ⬆️
dandi/utils.py 82.31% <0.00%> (+0.10%) ⬆️
dandi/support/threaded_walk.py 93.10% <0.00%> (+0.24%) ⬆️
dandi/files/zarr.py 88.03% <0.00%> (+1.17%) ⬆️
dandi/files/_private.py 98.03% <0.00%> (+2.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

Thanks!

@yarikoptic yarikoptic changed the title Fixed logic and commented temporarily broken dataset Fixed logic and commented a temporarily broken BIDS (lacking README) dataset Oct 31, 2022
@yarikoptic yarikoptic merged commit 82b99ca into master Oct 31, 2022
@yarikoptic yarikoptic deleted the typo branch October 31, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants