Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typing issue involving the outdated tmpdir_factory #1144

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 26, 2022

No description provided.

@jwodder jwodder added the tests Add or improve existing tests label Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 87.99% // Head: 88.05% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (458aa96) compared to base (4c81691).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
+ Coverage   87.99%   88.05%   +0.05%     
==========================================
  Files          73       73              
  Lines        8586     8586              
==========================================
+ Hits         7555     7560       +5     
+ Misses       1031     1026       -5     
Flag Coverage Δ
unittests 88.05% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/fixtures.py 98.08% <ø> (ø)
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jwodder jwodder merged commit 08a2a26 into master Oct 26, 2022
@jwodder jwodder deleted the fix-typing branch October 26, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant