-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update client-side publication workflow #1125
Conversation
According to https://www.githubstatus.com, GitHub Actions is currently experiencing problems, so it may take a while for the CI to be triggered. |
@jwodder - could you please resubmit to retrigger CI? github health is back to green but I guess "what is missed remains missed" |
@yarikoptic Done. |
Codecov ReportBase: 87.91% // Head: 87.90% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1125 +/- ##
==========================================
- Coverage 87.91% 87.90% -0.01%
==========================================
Files 73 73
Lines 8549 8569 +20
==========================================
+ Hits 7516 7533 +17
- Misses 1033 1036 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provide order only if provided and not provide None
for the value?
v = Version.parse_obj(self.client.get(f"{draft_api_path}info/")) | ||
if v.status is VersionStatus.PUBLISHED: | ||
break | ||
sleep(0.5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not thrilled about up to 240 requests to time out, but I guess that is the life.
🚀 PR was released in |
Closes #1119.