Retry Zarr entry uploads that fail with "header ... implies functionality ... not implemented" #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity ... not implemented"
jwodder
added
patch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1048 +/- ##
==========================================
+ Coverage 88.41% 88.42% +0.01%
==========================================
Files 71 71
Lines 9147 9149 +2
==========================================
+ Hits 8087 8090 +3
+ Misses 1060 1059 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
looks LGTM, thanks @jwodder. Added |
|
@yarikoptic That was a mistake, and I thought I got rid of it. |
|
sorry for the delay, let's contribute to the race of the releases! (just merged another |
|
🚀 PR was released in |
jwodder
added
the
HIFNI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1033.
It turns out the idea I had to get the filesize ourselves and retry failures wouldn't work, as
requestsignores user-supplied "Content-Length" headers. Hence, we have to actually do the request and retry that.An alternative approach would be to read the entire file into memory and PUT that, but I suspect the files get large enough that we want to avoid that.