Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better cancellation of Zarr uploads #1041

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Better cancellation of Zarr uploads #1041

merged 2 commits into from
Jul 5, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 1, 2022

Closes #1028.

@jwodder jwodder added the minor Increment the minor version when merged label Jul 1, 2022
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Attention: Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.39%. Comparing base (f7bb0a9) to head (0db7ecb).
Report is 1078 commits behind head on master.

Files Patch % Lines
dandi/files.py 73.68% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1041      +/-   ##
==========================================
+ Coverage   88.36%   88.39%   +0.02%     
==========================================
  Files          69       71       +2     
  Lines        9066     9141      +75     
==========================================
+ Hits         8011     8080      +69     
- Misses       1055     1061       +6     
Flag Coverage Δ
unittests 88.39% <91.07%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

Looks great to me, thank you @jwodder ! To prevent possibly more of "orphaned" uploads, I will also mark this for release.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Jul 5, 2022
@yarikoptic yarikoptic merged commit ca10803 into master Jul 5, 2022
@yarikoptic yarikoptic deleted the gh-1028 branch July 5, 2022 16:09
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

🚀 PR was released in 0.43.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Simultaneous uploads are not allowed" during single upload
2 participants