Merge pull request #1423 from dandi/gh-1422

Xfail flaky ontobee tests, unless running daily tests

.github/workflows/test.yml

@@ -89,6 +89,10 @@ jobs:
         echo HOME=/tmp/nfsmount/home >> "$GITHUB_ENV"
         echo DANDI_DEVEL_INSTRUMENT_REQUESTS_SUPERLEN=1 >> "$GITHUB_ENV"
 
+    - name: Use scheduled test configuration
+      if: github.event_name == 'schedule'
+      run: echo PYTEST_ADDOPTS=--schedule >> "$GITHUB_ENV"
+
     - name: Run all tests
       if: matrix.mode != 'dandi-api'
       run: |

dandi/conftest.py

@@ -12,6 +12,12 @@ def pytest_addoption(parser: Parser) -> None:
         default=False,
         help="Only run tests of the new Django Dandi API",
     )
+    parser.addoption(
+        "--scheduled",
+        action="store_true",
+        default=False,
+        help="Use configuration for a scheduled daily test run",
+    )
 
 
 def pytest_collection_modifyitems(items: list[Item], config: Config) -> None:

dandi/tests/test_metadata.py

@@ -29,6 +29,7 @@
 from dateutil.tz import tzutc
 from pydantic import ByteSize
 import pytest
+import requests
 from semantic_version import Version
 
 from .fixtures import SampleDandiset
@@ -53,6 +54,13 @@
 
 METADATA_DIR = Path(__file__).with_name("data") / "metadata"
 
+mark_xfail_ontobee = pytest.mark.xfail(
+    condition="not config.getoption('--scheduled')",
+    reason="Flaky ontobee site",
+    strict=False,
+    raises=requests.RequestException,
+)
+
 
 def test_get_metadata(simple1_nwb: Path, simple1_nwb_metadata: dict[str, Any]) -> None:
     target_metadata = simple1_nwb_metadata.copy()
@@ -234,6 +242,7 @@ def test_timedelta2duration(td: timedelta, duration: str) -> None:
     assert timedelta2duration(td) == duration
 
 
+@mark_xfail_ontobee
 @mark.skipif_no_network
 @pytest.mark.parametrize(
     "filename, metadata",
@@ -459,6 +468,7 @@ def test_time_extract_gest() -> None:
     )
 
 
+@mark_xfail_ontobee
 @mark.skipif_no_network
 @pytest.mark.obolibrary
 @pytest.mark.parametrize(
@@ -489,6 +499,7 @@ def test_parseobourl(url, value):
     assert parse_purlobourl(url) == value
 
 
+@mark_xfail_ontobee
 @pytest.mark.obolibrary
 @mark.skipif_no_network
 def test_species():